[podresapi 3/3] topology-aware: use Pod Resource API hints if present. #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klihub
force-pushed
the
devel/topology-aware/use-podresapi-hints
branch
2 times, most recently
from
603159e
to
544f53e
Compare
klihub
changed the title
klihub
force-pushed
the
devel/topology-aware/use-podresapi-hints
branch
from
544f53e
to
5fb185a
Compare
klihub
changed the title
|
/cc @pfl |
klihub
force-pushed
the
devel/topology-aware/use-podresapi-hints
branch
from
5fb185a
to
d539ff4
Compare
kad
reviewed
Dec 2, 2024
klihub
force-pushed
the
devel/topology-aware/use-podresapi-hints
branch
2 times, most recently
from
494fdd3
to
72bfdfc
Compare
fmuyassarov
reviewed
Dec 3, 2024
fmuyassarov
reviewed
Dec 3, 2024
There was a problem hiding this comment.
Since NodeResourceTopology can be disabled as well, should we extend this line to check if the NodeResourceTopology=true?
klihub
force-pushed
the
devel/topology-aware/use-podresapi-hints
branch
from
72bfdfc
to
33810b8
Compare
Add configuration for the agent itself. Currently the only control enables access to Node Resource Topology Custom Resources and it is on by default. Update the agent to honor its configuration. Signed-off-by: Krisztian Litkey <[email protected]>
Add support for tapping into the kubelet's pod resource API to query extra information about resources assigned to pods and containers. Use such a new client to expose agent functions for listing and querying pod resources, both synchronously and asynchronously. Signed-off-by: Krisztian Litkey <[email protected]>
Try querying Pod Resource API and generate extra topology hints using container device assignments listed there. Signed-off-by: Krisztian Litkey <[email protected]>
Bind-mount kubelet pod-resources directory read-only to plugin daemonset, to provide access to kubelet pod-resources socket. Signed-off-by: Krisztian Litkey <[email protected]>
Add functions for resolving partial, NUMA-only topology hints to fully defined CPU-specific ones using a sysfs instance. Signed-off-by: Krisztian Litkey <[email protected]>
Resolve potential partial NUMA-only topology hints to full CPU hints. Signed-off-by: Krisztian Litkey <[email protected]>
Update docs with a brief mention of how to enable topology hints based on Pod Resource API queries. Make mock tests compile again. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
devel/topology-aware/use-podresapi-hints
branch
from
33810b8
to
d05b4e1
Compare
Let's leave that for another PR. There are a few other similar things we could then take care of in the same PR, for instance not updating policy metrics if their collection is not enabled. |
fmuyassarov
reviewed
Dec 4, 2024
fmuyassarov
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series adds handling for extra topology hints acquired from the kubelet's Pod Resource API. If any such hints are found, they are fully resolved (from NUMA-only hints to cpuset-specific ones), before taken into account.